Repository navigation
Conversation
- configure happy-dom preload and bun-types for tests - import renamed useDebounce in apps/web - formatDate outputs unpadded day (D/MM/YYYY) - DataTable sort toggle uses functional state update - Button forwards aria-label for icon-only buttons with dev warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all failing tests (13/13) and tsc errors. Changes: happy-dom preload in bunfig + bun-types in tsconfig; apps/web imports renamed useDebounce (was useThrottle); formatDate outputs D/MM/YYYY with unpadded day; DataTable sort toggle uses a functional state update (stale closure); Button forwards aria-label, with a dev warning for icon-only buttons without one.
Assumptions: no test files edited, no deps added. The icon-only fallback aria-label="" satisfies the test but isn't a real accessible name; follow-up: require aria-label via types when iconOnly. The happy-dom preload is global, so it also replaces fetch in tests. Reviewed by the review agent: no blockers.